run-vmtest@v2 and build-selftests@v2 #150
Open
+233
−156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theihor
force-pushed
the
run-vmtest-v2
branch
from
4db1d56
to
ff45d47
Compare
theihor
changed the title
theihor
force-pushed
the
run-vmtest-v2
branch
11 times, most recently
from
fa191b0
to
08a3466
Compare
Previously the first run-vmtest action step would always search for vmlinux image in KERNEL_ROOT, and then copy it to path specified by inputs.vmlinuz However, the caller may want to pass vmlinux image directly. Change this behavior: search only inputs.vmlinuz was not passed. Signed-off-by: Ihor Solodrai <[email protected]>
Various changes in the scripts aimed to make run-vmtest action usable by libbpf/libbpf workflows: * Change how ALLOWLIST and DENYLIST are set up. A script executing in qemu (vmtest) is now expecting a single $ALLOWLIST_FILE and $DENYLIST_FILE which are parsed by read_lists as usual. This change makes it easier for an action caller to modify the lists, as they are often composed from a number of files. * Update vmtest init command (executed in qemu before the tests), to create a link from /boot to vmlinux being tested. This is necessary when older kernels are tested. * Allow some env variables to be defined outside of the scripts to give the caller more control over the action. That is, before setting a default value, check if the variable is set. * Remove env vars like $THISDIR, $PROJECT_NAME etc. in favor of $GITHUB_ACTION_PATH, $GITHUB_WORKSPACE and $KERNEL_ROOT * Move selftests running scripts from ci/vmtest to run-vmtest, so that they are local to the action Signed-off-by: Ihor Solodrai <[email protected]>
theihor
force-pushed
the
run-vmtest-v2
branch
4 times, most recently
from
5db3a07
to
766dd98
Compare
theihor
force-pushed
the
run-vmtest-v2
branch
2 times, most recently
from
9f45a6b
to
1c98688
Compare
Adjust run-vmtest scripts so that the action is callable from libbpf/libbpf, particularly with pre-built kernels. More environment variables can now be set by a caller to direct the scripts behavior: SELFTESTS_BPF, VERISTAT_CONFIGS, VMLINUX, VMLINUZ A symlink to standard vmlinux location is created before vmtest is executed to accomodate older kernels. The command passed tp vmtest is refactored, separating generic vmtet init and VMTEST_SCRIPT execution. Search and processing of json test summaries is now noop in case when no summaries are found. Signed-off-by: Ihor Solodrai <[email protected]>
FETCH_DEPTH now controls how to get linux source. If it's 0, the snapshot is searched for and downloaded if found. Otherwise git clone --depth $FETCH_DEPTH is executed, and .git is preserved. Signed-off-by: Ihor Solodrai <[email protected]>
Changes in action inputs: * kernel-root is now a required input * kernel, kbuild-output and max-make-jobs are removed kernel-root input is required, because to build selftests one must to clone a kernel source tree first. The build script behavior can be directed more granularly with env variables: * KBUILD_OUTPUT now defaults to the kernel-root * VMLINUX_BTF now can be set externally * MAX_MAKE_JOBS can be set as env variable if desired Preparation script logic is removed: the rationale is that the caller is responsible for setting up required environment before building. Signed-off-by: Ihor Solodrai <[email protected]>
Introduce CACHED_KERNEL_BUILD variable and change download/build steps to make use of the cached incremental build on libbpf/ci workflows. Change parameters passed to build-selftests. Add a step preparing allow/denylist before running vmtest. Signed-off-by: Ihor Solodrai <[email protected]>
theihor
force-pushed
the
run-vmtest-v2
branch
from
1c98688
to
73fe629
Compare
chantra
approved these changes
Nov 15, 2024
run-vmtest/run.sh
Outdated
| @@ -5,6 +5,11 @@ trap 'exit 2' ERR | |||
|
|
|||
| source "${GITHUB_ACTION_PATH}/../helpers.sh" | |||
|
|
|||
| if [[ -z "${VMLINUZ}" || ! -f "${VMLINUZ}" ]]; then | |||
There was a problem hiding this comment.
nit: Given that we don't use mode set -x, would it be useful to echo something along the line of vmlinuz not specified or not found, searching image.
| @@ -6,7 +6,7 @@ DIFF_DIR=$1 | |||
| for ext in diff patch; do | |||
| if ls ${DIFF_DIR}/*.${ext} 1>/dev/null 2>&1; then | |||
| for file in ${DIFF_DIR}/*.${ext}; do | |||
| if patch --dry-run -p1 -s < "${file}" 2>/dev/null; then | |||
| if patch --dry-run -N --silent -p1 -s < "${file}" 2>/dev/null; then | |||
There was a problem hiding this comment.
any reason for the -N here?
Comment on lines
+6
to
10
| # There are 2 ways to pass test names. | ||
| # 1) command-line arguments to this script | ||
| # 2) a comma-separated list of test names passed as `run_tests` boot parameters. | ||
| # test names passed as any of those methods will be ran. | ||
| # 2) a comma-separated list of test names passed as `run_tests` boot | ||
| # parameters. | ||
|
|
There was a problem hiding this comment.
this is probably more for historical reasons these days. Maybe we should support only one way. I believe the boot parameters approach is not used anymore since the move to vmtest. It was needed with the old image approach.
| env: | ||
| MAX_MAKE_JOBS: ${{ inputs.max-make-jobs }} |
There was a problem hiding this comment.
this used to be used to control how many cpus were used when compiling. On bare metal, with 96 CPUs, if all containers are building at the same time, they will all use that many CPUs, bringing the machine to a crawl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to various actions and scripts with breaking API changes. The goal of the changes is to make the actions usable by libbpf/libbpf#862.
See commits for details.